Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare news fragments for 1.6.0 #1431

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

Gitznik
Copy link
Contributor

@Gitznik Gitznik commented May 28, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Fixed the news fragments so they no longer break the formatting of the changelog.

Will create a release PR after this is merged.

Test plan

Tested by running

# command(s) to exercise these changes
nox -s watch_docs

@Gitznik
Copy link
Contributor Author

Gitznik commented May 28, 2024

Do we actually want to keep the news fragment for #1400? I don't think there is any reason to include it in the changelog.

@huxuan
Copy link
Member

huxuan commented May 28, 2024

Do we actually want to keep the news fragment for #1400? I don't think there is any reason to include it in the changelog.

I agree on removing it.

@Gitznik
Copy link
Contributor Author

Gitznik commented May 28, 2024

Do we actually want to keep the news fragment for #1400? I don't think there is any reason to include it in the changelog.

I agree on removing it.

Done

@Gitznik Gitznik merged commit c819aab into pypa:main May 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants